Skip to content

E2E: QA: Add .prettierrc.json to acceptance tests for formatting consistency#22751

Merged
nhudinh0309 merged 1 commit into
mainfrom
v17/QA/add-prettierrc-for-consistency
May 8, 2026
Merged

E2E: QA: Add .prettierrc.json to acceptance tests for formatting consistency#22751
nhudinh0309 merged 1 commit into
mainfrom
v17/QA/add-prettierrc-for-consistency

Conversation

@andr317c

@andr317c andr317c commented May 7, 2026

Copy link
Copy Markdown
Contributor

Adds a .prettierrc.json to the acceptance tests so IDEs with the Prettier plugin format new edits to match the existing style (2 spaces, single quotes, printWidth: 200).

Copilot AI review requested due to automatic review settings May 7, 2026 13:38
@claude

claude Bot commented May 7, 2026

Copy link
Copy Markdown

Claude finished @andr317c's task in 1m 19s —— View job


PR Review

Target: origin/main · Based on commit: 6a209ef1 · Classified as: Config-only

Adds a .prettierrc.json to the acceptance test project so IDE Prettier plugins format new files consistently with the existing code style.


Suggestions

  • tests/Umbraco.Tests.AcceptanceTest/.prettierrc.json:7: "endOfLine": "auto" means Prettier will preserve the existing line ending style on each machine rather than enforcing a consistent target. If the repo enforces LF via .gitattributes, consider "endOfLine": "lf" to make Prettier actively enforce that on save. Not a blocker — "auto" is safe if the team is on mixed OS.

Approved

The settings align with the actual formatting found in existing test files (2-space indent, single quotes, no bracket spacing). Good addition for IDE consistency.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a Prettier configuration file to the Umbraco.Tests.AcceptanceTest workspace to help editors/IDEs auto-format JS/TS edits consistently within the acceptance test package.

Changes:

  • Introduces tests/Umbraco.Tests.AcceptanceTest/.prettierrc.json with formatting rules (2-space indentation, single quotes, wider line length).

@nhudinh0309 nhudinh0309 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhudinh0309 nhudinh0309 merged commit 54ded68 into main May 8, 2026
34 checks passed
@nhudinh0309 nhudinh0309 deleted the v17/QA/add-prettierrc-for-consistency branch May 8, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants